Could anyone give general comments on
formatting link
?Is my coding approach too software-centric ?
logic scope coding
Sep 16, 2017
1 Replies
From just a quick look, my only recommendation would be to avoid the `defines within the RTL code, and use parameters instead. You've got some parameters in the code, but `defines elsewhere. I'd recommend standardizing on parameters.
`defines are global in scope, and not recommended for the way you're using them. Imagine a design requiring two of your logic_analyzer - each with its own configuration.
Regards,
Mark
Join the Discussion
Have something to add? Share your thoughts — no account required.
Didn't find your answer?
Ask the community — no account required