logic scope coding

Could anyone give general comments on

formatting link
?

Is my coding approach too software-centric ?

Reply to
promach
Loading thread data ...

From just a quick look, my only recommendation would be to avoid the `defines within the RTL code, and use parameters instead. You've got some parameters in the code, but `defines elsewhere. I'd recommend standardizing on parameters.

`defines are global in scope, and not recommended for the way you're using them. Imagine a design requiring two of your logic_analyzer - each with its own configuration.

Regards,

Mark

Reply to
Mark Curry

ElectronDepot website is not affiliated with any of the manufacturers or service providers discussed here. All logos and trade names are the property of their respective owners.