at91rm9200dk u-boot port messed up...

Hi Rick,

Dataflash is an Atmel Trademark so it is correct to use the name "dataflash.c" for an AT45DBxxx specific driver and CFG_DATAFLASH for the configuration

Atmel does not call AT25Fxxx chips Dataflash(tm) even if they are flash and use the SPI bus.

CFG_DATAFLASH should be used for AT45DB and nothing else or you willl be violating the trademark. If you have another SPI flash you need to come up with "CFG_SPIBOOT" or something else.

--
Best Regards,
Ulf Samuelsson
ulf@a-t-m-e-l.com
This message is intended to be my own personal view and it
may or may not be shared by my employer Atmel Nordic AB

Thought that this would be some trademark issue...

but then again this would mean that in the "common" source tree

2 different configurations are using the same code...which should have been avoided by firstly using "CFG_SPI_BOOT" in the common source tree.

So it is just bad coding in my and others oppinion by thinking that Atmel might be the only platform using SPI (o;

Guess I have to go through all the "trademark" mess and remove all appearance of "CFG_DATAFLASH" in the "common/" source tree...

rick

And you will test these modifications thoroughly to ensure that you do not break AT91RM9200 support? I suggest you let things remain if you dont plan to do that and add your own configurations elsewhere. I think that this forum is the wrong place to have this debate. There are good distribution list with a lot of knowledgeable people that can judge the consequences of your actions.

--
Best Regards,
Ulf Samuelsson
ulf@a-t-m-e-l.com
This message is intended to be my own personal view and it
may or may not be shared by my employer Atmel Nordic AB

Don't plan to spend 1600 Euros just for cleaning up code (o;

May I take this personally? (o;

rick